Create docker-build.yml #7
Conversation
Signed-off-by: Simon L <[email protected]>
| username: ${{ secrets.DOCKERHUB_USERNAME }} | ||
| password: ${{ secrets.DOCKERHUB_TOKEN }} |
There was a problem hiding this comment.
you would need to add these as action secrets in the repo settings
There was a problem hiding this comment.
Even the free account on docker hub is sufficient btw. You don't need to buy any subscription there.
There was a problem hiding this comment.
@matiasdelellis you will need to add these secrets to the repo if not done already...
| context: './' | ||
| no-cache: true | ||
| file: 'Dockerfile' | ||
| tags: matiasdelellis/facerecognition-external-model:${{ github.event.inputs.tagName }} |
There was a problem hiding this comment.
the name can be changed of course to something else if required
|
@matiasdelellis would you mind reviewing this? |
|
Great.. Thanks you so much!!!. 😄 |
|
@matiasdelellis after adding the secrets to the repo, you should be able to create a new docker image by going to https://github.com/matiasdelellis/facerecognition-external-model/actions/workflows/docker-build.yml and then using the |
For goodspb/pdlib#56 (comment)
and #8