rpc, ethclient: cater 'finalized' and 'safe' blocks in ethclient #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 56.80% // Head: 56.73% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v0.2.18-candidate #517 +/- ##
=====================================================
- Coverage 56.80% 56.73% -0.08%
=====================================================
Files 578 578
Lines 68307 68319 +12
=====================================================
- Hits 38805 38761 -44
- Misses 26154 26208 +54
- Partials 3348 3350 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
JekaMas
approved these changes
Sep 21, 2022
cffls
approved these changes
Sep 21, 2022
pratikspatil024
approved these changes
Sep 21, 2022
manav2401
added a commit
that referenced
this pull request
Sep 22, 2022
* rpc: add finalized and safe block types * ethclient: honour safe and finalized block requests * fix: remove BlockByNumberWithoutTx function
manav2401
added a commit
that referenced
this pull request
Sep 22, 2022
… (#523) * rpc: add finalized and safe block types * ethclient: honour safe and finalized block requests * fix: remove BlockByNumberWithoutTx function
cffls
pushed a commit
to cffls/bor
that referenced
this pull request
Sep 29, 2022
…icnetwork#517) (maticnetwork#523) * rpc: add finalized and safe block types * ethclient: honour safe and finalized block requests * fix: remove BlockByNumberWithoutTx function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new block type for "finalized and "safe" blocks to honour the post-merge API modifications.
The purpose behind this change is to consume this client in heimdall for L1 communication i.e. ethereum mainnet and goerli test network which are already following these notions.
Reference implementation from geth: ethereum/go-ethereum#24282, ethereum/go-ethereum#25165, ethereum/go-ethereum#25580.
NOTE: This by no means adds/serves "finalized" or "safe" blocks from bor.