Migrate to eufy-security-client #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main driver behind this change are issues with Firebase registration - see matijse#78 for details. Aside from different name, the main change is how the registration is handled. Eufy-security-client's new `PushNotificationService` class handles the registration itself if needed and emits the 'credential' event when it happens. On our side, we just listen to this event and persist credentials to disk. In future, we may want to stop listening to raw events and use normalized messages provided by `PushNotificationService` instead. This would potentially allow supporting more devices.
skrobul
force-pushed
the
switch-to-new-lib
branch
from
06695e8 to
9f2571e
Compare
|
Thanks for this contribution! I've decided to no longer actively develop this script, because I don't have enough time and a better alternative for Home Assistant is developed already (see https://github.com/fuatakgun/eufy_security) I am still open to contributions from others, so this PR can still be merged. But before merging I want to try it out... I can't do that right now, but will try to do it this week. However, glancing over the code, it looks good to me. |
|
Would using this PR also make it possible to use the enable/disable device notifications feature in the eufy-security-client library? It would be useful to stop these when I need to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main driver behind this change are issues with Firebase registration - see
#78 for details. Also, the
eufy-node-clienthas been deprecated.Aside from a different name, the main change is how the registration is handled.
Eufy-security-client's new
PushNotificationServiceclass handles theregistration itself if needed and emits the 'credential' event when it happens.
On our side, we just listen to this event and persist credentials to disk.
In future, we may want to stop listening to raw events and use normalized
messages provided by
PushNotificationServiceinstead. This would potentiallyallow supporting more devices.
The new library supposedly supports the 2FA as well, but I have not tried it yet.