Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is forked off of #15, so most of the first commits are from that (githubs UI handles this poorly). I'll rebase after that merges, which will fix the issue. Until then, the last commit of this is actually where the meat is.
This takes a stab at implementing enum support. I think it supports most common uses, although I haven't tested it exhaustively.
That said, it's kind not the best and I'm unsure how I feel about it:
visit_enums
thing is probably the wrong approach and likely can be simplified.Ty::Enum
is unlike the otherTy
variants in a bunch of ways and code usually either--format format: text | json | csv
.I don't know how many of these are worth fixing, and how many are deliberate wontfixes (and how many are worth fixing someday but not urgently). I think it's probably a mix, tbh (I just felt like it was worth writing this stuff out while I still had it).
Anyway, I'm done poking at this at the moment, and figured I'd push it up for now.