support for multiline doc comments #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Mar 7, 2021
There was a problem hiding this comment.
Let's make a comment multiline here: https://github.com/matklad/xflags/blob/master/xflags-macros/tests/it/src/help.rs
| None => return Ok(None), | ||
| }; | ||
|
|
||
| loop { |
There was a problem hiding this comment.
This is :) . I guess lately I've been feeling that explicit match is more clear sometimes, but I'm happy to change it.
Just to clarify, I'll just need to make a multiline comment in the macro call to show everything compiles, but don't need to add a test for the exact help output? |
|
Yup, just add a multilingual comment, so that we can manually inspect the generated code and see that it’s reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.