Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added possibility to set any custom tracking parameters for 3rd party plugins #15

Merged
merged 1 commit into from
Nov 11, 2015

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 8, 2015

Eg needed for Custom Dimensions plugin ( matomo-org/matomo#9129 )

@tsteur tsteur added this to the Current sprint milestone Nov 8, 2015
@@ -304,6 +305,27 @@ public function clearCustomVariables()
$this->eventCustomVar = array();
}

/**
* Sets a custom tracking paramater. This is useful if you need to send any tracking parameters for a 3rd party
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paramater -> parameter

@tsteur tsteur force-pushed the customparameters branch 2 times, most recently from 2afa2f6 to d4e25a1 Compare November 9, 2015 19:47
@tsteur
Copy link
Member Author

tsteur commented Nov 9, 2015

Applied changes and rebased.

@tsteur
Copy link
Member Author

tsteur commented Nov 10, 2015

@mattab is it ok to merge this one?

mattab pushed a commit that referenced this pull request Nov 11, 2015
Added possibility to set any custom tracking parameters for 3rd party plugins
@mattab mattab merged commit ac3e26b into master Nov 11, 2015
@mattab
Copy link
Member

mattab commented Nov 11, 2015

Looks good to me

@mattab mattab deleted the customparameters branch November 11, 2015 02:56
@innocraft-automation innocraft-automation removed this from the Current sprint milestone Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants