handle new cookie values #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
reviewed
Sep 7, 2020
| $this->cookieVisitorId = $parts[0]; | ||
| $this->createTs = $parts[1]; | ||
| $this->visitCount = (int)$parts[2]; |
There was a problem hiding this comment.
@diosmosis we will still also need to support the old cookies just in case. That's because say
- You update Matomo to Matomo 4
- You also update the PHP tracker
- Then a visitor visits your website who didn't visit your website in a while. Then the old cookie structure will be sent. Possible that not even the tracking code is embedded on that same page.
We could check maybe how many parts are included and then use old or new strategy?
There was a problem hiding this comment.
@tsteur The only parts of the old cookie that are used in Matomo 4 are the first two elements. So if a cookie w/ more items comes in, it should still work. Unless I'm missing something? (There's a test for this, btw.)
|
Makes sense @diosmosis I think the PR should be made against 4.x-dev though if I understand things correctly in #72 (comment) |
|
Feel free to merge but needs to be merged for the different branch I think... |
|
👍 |
|
closing in favor of #79 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix matomo-org/matomo#16397
Not currently running on travis but could probably be easy to add.