Fix server side device fingerprinting failing in edge cases. #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An actual race here is presumably unlikely, but if it were to happen it makes more sense for all these preferences to be set together rather than alternating between multiple calls.
|
@kevinslashslash what do you think? |
…cted on subsequent `track` calls.
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
============================================
- Coverage 86.39% 86.38% -0.01%
+ Complexity 375 372 -3
============================================
Files 33 33
Lines 1426 1425 -1
Branches 168 167 -1
============================================
- Hits 1232 1231 -1
- Misses 122 123 +1
+ Partials 72 71 -1
Continue to review full report at Codecov.
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #310
Inject device infos for fingerprinting into every packet.