-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release job and automatic changelog #334
Conversation
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
============================================
+ Coverage 86.78% 86.85% +0.07%
- Complexity 371 372 +1
============================================
Files 33 33
Lines 1415 1415
Branches 165 165
============================================
+ Hits 1228 1229 +1
Misses 117 117
+ Partials 70 69 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat, looking forward to see the changelog generator in action 😎.
One small question, see comment.
Something like matomo-org/matomo#17809 might also be useful here |
Because I want to test it, I introduce a pre-release ability |
Pre-relase is working, but changelog not |
11b4a87
to
49cde38
Compare
I made a test release https://github.com/hannesa2/matomo-sdk-android/releases in my fork, and there at least, it was working |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it only work for master maybe?
No, it works on a branch as well. Even pull request with merge commit and pull request with rebased commit. Here are my tests https://github.com/hannesa2/matomo-sdk-android/releases I've no clue, why the tests in this repository where without changelog. Maybe merge it and lighten a candle that next time on real release it will work on this repo as well ? |
I removed the pre-release because it can't show tag in caption Now it works like this gain. But without the pre-release ability Please see my tests https://github.com/hannesa2/matomo-sdk-android/releases |
A new release needs now only a new tag, eg
Then the release pipeline starts and generates a changelog, depended on labels of pull request.
This means a label on pull request makes sense now, if you want to see it in release changelog,
All is untested and copy&paste from https://github.com/MikeOrtiz/TouchImageView where it works like this