Avoid clearing dispatcher when user changes optOut setting #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are good, but they need an adaption too |
|
Fixed. Sorry for that. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #476 +/- ##
============================================
- Coverage 87.12% 87.11% -0.01%
Complexity 364 364
============================================
Files 32 32
Lines 1429 1428 -1
Branches 165 165
============================================
- Hits 1245 1244 -1
Misses 115 115
Partials 69 69 ☔ View full report in Codecov by Sentry. |
hannesa2
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes #474
Basically setting setting setOptOut always clears dispatcher. It should set only flag and events should be omitted, not cleared.