Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of a persistent event queue #408

Merged
merged 6 commits into from
Sep 6, 2024

Conversation

brototyp
Copy link
Member

This is for the most of it a copy of PR #377.

@brototyp brototyp force-pushed the feature/137-userdefaults-queue branch 2 times, most recently from 251d5f1 to 9c36af7 Compare March 27, 2022 15:06
Copy link

@bobunmeng bobunmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks more sophisticated and it doesn't break the previous flow. I would go with this with no problem.
What I thought of previously was that a user doesn't have to bother creating their own queue if they want to persist their events. An argument "true" or "false" would do and we would do the rest of work from that.

@brototyp
Copy link
Member Author

What I thought of previously was that a user doesn't have to bother creating their own queue if they want to persist their events. An argument "true" or "false" would do and we would do the rest of work from that.

That's a legit point. I think there is a bit of tweaking we can do with this implementation to make the usage easier. The think I really like with this implementation that it is very customizable. A user of the SDK would be able to implement yet another queue that fits their very special need, e.g. encrypt and persist it, or persist it in a database or so.

Maybe the persisted: Bool parameter could be in a convenience initializer. This way we could have the best of both worlds. At the same time: Maybe the persisted queue should become the default queue. If it is reliable, I think it might be worth the tradeoff (reduced performance but no (or much less) event loss).

# Conflicts:
#	Podfile
… app

# Conflicts:
#	Example/ios/ios.xcodeproj/project.pbxproj
# Conflicts:
#	CHANGELOG.md

# Conflicts:
#	CHANGELOG.md
@brototyp brototyp force-pushed the feature/137-userdefaults-queue branch 2 times, most recently from 417773f to b3468f3 Compare September 6, 2024 09:13
@brototyp brototyp force-pushed the feature/137-userdefaults-queue branch from 238af60 to 31f1384 Compare September 6, 2024 09:27
@brototyp brototyp merged commit 98fb04c into develop Sep 6, 2024
7 checks passed
@brototyp brototyp deleted the feature/137-userdefaults-queue branch September 6, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants