-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
added some tests for segment formatting and bugfixes
- Loading branch information
Showing
7 changed files
with
157 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
110 changes: 110 additions & 0 deletions
110
plugins/SegmentEditor/tests/Integration/SegmentFormatterTest.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| <?php | ||
| /** | ||
| * Piwik - free/libre analytics platform | ||
| * | ||
| * @link http://piwik.org | ||
| * @license http://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later | ||
| */ | ||
|
|
||
| namespace Piwik\Plugins\SegmentEditor\tests\Integration; | ||
|
|
||
| use Piwik\Plugins\SegmentEditor\SegmentFormatter; | ||
| use Piwik\Plugins\SegmentEditor\SegmentList; | ||
| use Piwik\Tests\Framework\Fixture; | ||
| use Piwik\Tests\Framework\Mock\FakeAccess; | ||
| use Piwik\Tests\Framework\TestCase\IntegrationTestCase; | ||
| use Piwik\Translate; | ||
| use Exception; | ||
|
|
||
| /** | ||
| * @group SegmentFormatterTest | ||
| * @group SegmentFormatter | ||
| * @group SegmentEditor | ||
| * @group Plugins | ||
| */ | ||
| class SegmentFormatterTest extends IntegrationTestCase | ||
| { | ||
| /** | ||
| * @var SegmentFormatter | ||
| */ | ||
| private $formatter; | ||
|
|
||
| private $idSite; | ||
|
|
||
| public function setUp() | ||
| { | ||
| parent::setUp(); | ||
|
|
||
| $this->idSite = Fixture::createWebsite('2012-01-01 00:00:00'); | ||
| $this->formatter = new SegmentFormatter(new SegmentList()); | ||
|
|
||
| Translate::loadAllTranslations(); | ||
| } | ||
|
|
||
| public function tearDown() | ||
| { | ||
| Translate::reset(); | ||
| } | ||
|
|
||
| public function test_getHumanReadable_noSegmentGiven_ShouldReturnDefaultSegment() | ||
| { | ||
| $readable = $this->formatter->getHumanReadable($segment = '', $this->idSite); | ||
| $this->assertSame('All visits', $readable); | ||
| } | ||
|
|
||
| public function test_getHumanReadable_ShouldTranslateAMetric() | ||
| { | ||
| $readable = $this->formatter->getHumanReadable($segment = 'visitCount>5', $this->idSite); | ||
| $this->assertSame('Number of visits greater than "5"', $readable); | ||
|
|
||
| $readable = $this->formatter->getHumanReadable($segment = 'visitCount==5', $this->idSite); | ||
| $this->assertSame('Number of visits equals "5"', $readable); | ||
| } | ||
|
|
||
| public function test_getHumanReadable_ShouldTranslateADimension() | ||
| { | ||
| $readable = $this->formatter->getHumanReadable($segment = 'resolution=@1024', $this->idSite); | ||
| $this->assertSame('Resolution contains "1024"', $readable); | ||
|
|
||
| $readable = $this->formatter->getHumanReadable($segment = 'resolution==1024x768', $this->idSite); | ||
| $this->assertSame('Resolution is "1024x768"', $readable); | ||
| } | ||
|
|
||
| public function test_getHumanReadable_ShouldCombineMultipleSegmentDefinitionsWithBooleanOperator() | ||
| { | ||
| $readable = $this->formatter->getHumanReadable($segment = 'browserVersion!=1.0;browserEngine=$Trident', $this->idSite); | ||
| $this->assertSame('Browser version is not "1.0" and Browser engine ends with "Trident"', $readable); | ||
|
|
||
| $readable = $this->formatter->getHumanReadable($segment = 'browserVersion!=1.0,browserEngine=$Trident', $this->idSite); | ||
| $this->assertSame('Browser version is not "1.0" or Browser engine ends with "Trident"', $readable); | ||
| } | ||
|
|
||
| public function test_getHumanReadable_ShouldHandleAMissingValue() | ||
| { | ||
| $readable = $this->formatter->getHumanReadable($segment = 'browserVersion==', $this->idSite); | ||
| $this->assertSame('Browser version is null or empty', $readable); | ||
|
|
||
| $readable = $this->formatter->getHumanReadable($segment = 'browserVersion!=', $this->idSite); | ||
| $this->assertSame('Browser version is not null nor empty', $readable); | ||
| } | ||
|
|
||
| /** | ||
| * @expectedException \Exception | ||
| * @expectedExceptionMessage The segment 'noTexisTinG' does not exist | ||
| */ | ||
| public function test_getHumanReadable_ShouldThrowAnException_IfTheGivenSegmentNameDoesNotExist() | ||
| { | ||
| $this->formatter->getHumanReadable($segment = 'noTexisTinG==1.0', $this->idSite); | ||
| } | ||
|
|
||
| /** | ||
| * @expectedException \Exception | ||
| * @expectedExceptionMessage The segment 'pageUrl=!1.0' is not valid. | ||
| */ | ||
| public function test_getHumanReadable_ShouldThrowAnException_IfSegmentCannotBeParsedBecauseOfInvalidFormat() | ||
| { | ||
| $invalidOperator = '=!'; | ||
| $this->formatter->getHumanReadable($segment = 'pageUrl' . $invalidOperator . '1.0', $this->idSite); | ||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule expected-ui-screenshots
updated
from 9fffaf to 4cf739