Update GitHub links in tests/README.md #14631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: Two of the links link to a 404. However I didn't remove them, because I didn't know what way you like to handle such a case. 1. https://github.com/matomo-org/matomo/blob/master/tests/PHPUnit/config.ini.travis.php#L23-27 (Line 156) 2. https://github.com/matomo-org/matomo/blob/master/tests/README.xhprof.md (Line 179) I still think that adjusting these links is right however because /piwik/ will be a 404 sometime anyway.
|
Thanks again 👍 |
mattab
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
Two of the links link to a 404. However I didn't remove them, because I didn't know what way you like to handle such a case.
(Line 156)
(Line 179)
I still think that adjusting these links is right however because
/piwik/will be a 404 someday anyway.