Update to PHPUnit 8.5 #15581
Merged
Update to PHPUnit 8.5 #15581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
c: Tests & QA
sgiehl
added
the
Pull Request WIP
sgiehl
force-pushed
the
updatedeps
branch
2 times, most recently
from
1589a19 to
5179456
Compare
This was referenced Feb 24, 2020
sgiehl
force-pushed
the
updatedeps
branch
3 times, most recently
from
ada2fd8 to
e0d6d61
Compare
sgiehl
removed
the
Pull Request WIP
sgiehl
force-pushed
the
updatedeps
branch
3 times, most recently
from
8c5c04f to
ed8fd83
Compare
sgiehl
removed
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are still using PHPUnit 4.8. Support for that version already ended in 2017
PHPUnit 8.5 requires at least PHP 7.2. PHPUnit 9 was already released but it requires PHP 7.3. So we can only update after removing PHP 7.2 support.
This PR is including various adjustments for all tests cause of namespace and method changes within PHPUnit:
@expectedException \Exceptionannotation is no longer supported. Instead$this->expectException(\Exception::class);needs to be used. Similar for@expectedExceptionMessage, ...assertContains,getMockwith multiple parameters orassertInternalTypesetUp(),tearDown(),setUpBeforeClass(),tearDownAfterClassneeds to be defined with: voidreturn type hintsubmodule plugins are already done. will create PRs for those and all other plugins the coming days