Revert "Process unique visitor metric for Roll-ups (set enable_processing_unique_visitors_multiple_sites = 1)" #15701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it also help to emit some kind of error when config has mismatched values? |
|
It does during archiving should a roll up be configured. |
diosmosis
deleted the
revert-15450-enable_processing_unique_visitors_multiple_sites
branch
|
FYI @mattab, merged this |
mattab
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #15450
The previous PR will only work when
enable_fingerprinting_across_websitesis also enabled. This is a privacy issue though. As a result archiving will break with roll up reporting etc. I reckon this PR should therefore be reverted as it broke RollUpReporting and fixing that would cause privacy issues.