Handle ignoring of duplicates the same when not using INSERT SELECT #22625
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If
INSERT INTO ... SELECT
can not be used due to unsupported transaction level changes, Matomo falls back to performing a SELECT query followed by an INSERT query.Both behaviors currently differ by the fact, that
INSERT INTO ... SELECT
ignores duplicates on purpose, while the pureINSERT
statement doesn't.This PR adjusts the pure
INSERT
statement, so it also ignores duplicates.refs #18937
(Ref DEV-3515)
Review