Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ignoring of duplicates the same when not using INSERT SELECT #22625

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Sep 27, 2024

Description:

If INSERT INTO ... SELECT can not be used due to unsupported transaction level changes, Matomo falls back to performing a SELECT query followed by an INSERT query.

Both behaviors currently differ by the fact, that INSERT INTO ... SELECT ignores duplicates on purpose, while the pure INSERT statement doesn't.

This PR adjusts the pure INSERT statement, so it also ignores duplicates.

refs #18937

(Ref DEV-3515)

Review

@sgiehl sgiehl added Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Sep 27, 2024
@sgiehl sgiehl added this to the 5.2.0 milestone Sep 27, 2024
@sgiehl sgiehl requested a review from a team September 27, 2024 14:39
@mneudert mneudert merged commit 5c6f7b9 into 5.x-dev Sep 27, 2024
24 of 25 checks passed
@mneudert mneudert deleted the ignoreduplicates branch September 27, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants