Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refs #3882 Use table instead of tableGoals on Visits-Days to Conversion reports #53

Closed
wants to merge 2 commits into from
Closed

refs #3882 Use table instead of tableGoals on Visits-Days to Conversion reports #53

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3e8788
refs #3882 Use table instead of tableGoals on Visits-Days to Conversi…
Apr 8, 2013
c5439aa
tabs / spaces...
Apr 8, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions plugins/Goals/Controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,11 +359,11 @@ protected function getTopDimensions($idGoal)
$topDimensions = array();
foreach ($topDimensionsToLoad as $dimensionName => $apiMethod) {
$request = new Piwik_API_Request("method=$apiMethod
&format=original
&filter_update_columns_when_show_all_goals=1
&idGoal=" . Piwik_DataTable_Filter_AddColumnsProcessedMetricsGoal::GOALS_FULL_TABLE . "
&filter_sort_order=desc
&filter_sort_column=$columnNbConversions" .
&format=original
&filter_update_columns_when_show_all_goals=1
&idGoal=" . Piwik_DataTable_Filter_AddColumnsProcessedMetricsGoal::GOALS_FULL_TABLE . "
&filter_sort_order=desc
&filter_sort_column=$columnNbConversions" .
// select a couple more in case some are not valid (ie. conversions==0 or they are "Keyword not defined")
"&filter_limit=" . (self::COUNT_TOP_ROWS_TO_DISPLAY + 2));
$datatable = $request->process();
Expand Down Expand Up @@ -522,6 +522,9 @@ private function getGoalReportsByDimensionTable($conversions, $ecommerce = false
foreach ($allReports as $category => $reports) {
$categoryText = Piwik_Translate('Goals_ViewGoalsBy', $category);
foreach ($reports as $report) {
if ($report['module'] == 'Goals') {
$customParams['viewDataTable'] = 'table';
}
$goalReportsByDimension->addReport(
$categoryText, $report['name'], $report['module'] . '.' . $report['action'], $customParams);
}
Expand Down