Run UI tests on PHP 5.4 in Piwik 3.0 branch #8452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
| install: | ||
| - git fetch -q | ||
|
|
||
| - export GENERATE_TRAVIS_YML_COMMAND="php ./tests/travis/generator/main.php generate:travis-yml --core --verbose" | ||
| - '[[ "$TRAVIS_JOB_NUMBER" != *.1 || "$TRAVIS_PULL_REQUEST" != "false" ]] || ./tests/travis/autoupdate_travis_yml.sh' | ||
| # Disable it until this is in master, otherwise we have to create a branch for travis submodule |
There was a problem hiding this comment.
I really wanted to avoid having to keep a branch of travis submodule in sync. I reckon it's ok to just not have this activated for now. Not sure how to make sure we won't forget to enable it again. Of course we can create an issue but chances are high we won't look into that issue... I will create one though if we merge this PR
There was a problem hiding this comment.
Sounds good to me, cc @diosmosis maybe you have some thoughts
There was a problem hiding this comment.
We already talked about it
tsteur
added
Pull Request WIP
tsteur
added
Needs Review
tsteur
added a commit
that referenced
this pull request
Jul 29, 2015
Run UI tests on PHP 5.4 in Piwik 3.0 branch
|
What a good feeling to get rid of 5.3.x! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7323 we announced to drop support for PHP 5.3 in Piwik 3.0.
In this PR I changed to run the UI tests to PHP 5.4 as it is needed by PRs like this #8449 which requires PHP 5.4. UI tests seem to run quite a bit faster (finished in 28 minutes but possible we got a good VM)
If someone knows what the lowest available PHP 5.4 version on Travis is, let me know. I couldn't find that information. Right now they will run on the latest PHP 5.4
I also removed some code in tests that marked tests as skipped if they run on PHP 5.3. This will be no longer needed. BTW: It feels really good to remove them.
If a super user is logged in, we currently show a message PHP 5.3 has reached EOL etc. I changed this to PHP 5.4 as it reaches soon EOL and by the time it will have reached for sure. I removed the message that we will drop support for PHP 5.4 though (as we won't do this for now).
In another PR we can remove more "hacks" or workarounds that were made for PHP 5.3