-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating dependency to eliminate deprecation warning #165
Conversation
This eliminates the deprecation error, but it doesn't support PHP 7.2. We might have to try a different library or use rector to downgrade. What do you think @AltamashShaikh ? |
@snake14 We should try with Rector once and take a decision accordingly. |
@AltamashShaikh @snake14 I'm actually not sure if it's worth the effort to use rector to make that library compatible with PHP 7.2 again. As this plugin is mainly used for development purpose, the warning might not be that problematic. |
This reverts commit f85704e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to generate visits with this branch successfully :+1
Description:
Updating dependency to eliminate deprecation warning. The old dependency is no longer supported, so we had to switch to a fork which supports PHP 8.0.
Fixes: #164
Review