Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating dependency to eliminate deprecation warning #165

Merged
merged 11 commits into from
Feb 17, 2025

Conversation

snake14
Copy link
Contributor

@snake14 snake14 commented Feb 3, 2025

Description:

Updating dependency to eliminate deprecation warning. The old dependency is no longer supported, so we had to switch to a fork which supports PHP 8.0.

Fixes: #164

Review

@snake14
Copy link
Contributor Author

snake14 commented Feb 3, 2025

This eliminates the deprecation error, but it doesn't support PHP 7.2. We might have to try a different library or use rector to downgrade. What do you think @AltamashShaikh ?

@AltamashShaikh
Copy link
Contributor

This eliminates the deprecation error, but it doesn't support PHP 7.2. We might have to try a different library or use rector to downgrade. What do you think @AltamashShaikh ?

@snake14 We should try with Rector once and take a decision accordingly.

@sgiehl
Copy link
Member

sgiehl commented Feb 4, 2025

@AltamashShaikh @snake14 I'm actually not sure if it's worth the effort to use rector to make that library compatible with PHP 7.2 again. As this plugin is mainly used for development purpose, the warning might not be that problematic.
I would rather suggest to try if the warning can be easily suppressed. As long as that's only a deprecation warning, rather than a real problem that should be fine in this case.
Once we dropped support for PHP 7, which might happen with the next major release, we can then easily update the library here without additional effort.

@AltamashShaikh
Copy link
Contributor

@sgiehl We have a command created to apply rector in 1 step, so I suggested that.

@snake14 Feel free to pick any approach, which solves the issue in quick time :)

Copy link
Contributor

@AltamashShaikh AltamashShaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to generate visits with this branch successfully :+1

AltamashShaikh
AltamashShaikh previously approved these changes Feb 17, 2025
@snake14 snake14 merged commit 266b522 into 5.x-dev Feb 17, 2025
5 checks passed
@snake14 snake14 deleted the PG-4119-deprecation-warning branch February 17, 2025 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warning from vendored library
3 participants