This repository has been archived by the owner on Jan 20, 2025. It is now read-only.
Automatically run tests against maximum supported piwik version #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upported piwik version
| $comparison = $required['comparison']; | ||
| $version = $required['version']; | ||
|
|
||
| if (in_array($comparison, array('>=','>', '=='))) { |
There was a problem hiding this comment.
So far we only consider a few comparisons and not all ('<>', '!=', '<', '<=') as it otherwise gets quickly very complicated. In the past we've never considered any of these so it shouldn't be a problem for now.
tsteur
changed the title
|
@tsteur where should we document this behavior? Maybe in http://developer.piwik.org/guides/tests-travis ? |
mattab
pushed a commit
that referenced
this pull request
Jan 27, 2016
Automatically run tests against maximum supported piwik version
|
I added a little doc here matomo-org/developer-documentation@e0beeeb#diff-0409dd8dad78d88117d7dba9d15db893 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs matomo-org/matomo#8695
Tested it here
"piwik": ">=2.15.0-rc1) https://travis-ci.org/piwik/plugin-AnonymousPiwikUsageMeasurement/jobs/101955204"piwik": ">=2.15.0-rc1,<=2.15.1-b11") In this case max supported version is 2.15.1-b11 https://travis-ci.org/piwik/plugin-AnonymousPiwikUsageMeasurement/builds/101955789Made it in a way that it should be backwards compatible and in a way that it is still possible to specify a specific Piwik target version instead of automatically using the maximum supported Piwik version from plugin.json.
Also see comment in matomo-org/matomo#8695 (comment)