Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the ipykernel dependency with an IPython dependency? #409

Closed
martinRenou opened this issue Dec 15, 2021 · 2 comments · Fixed by #410
Closed

Replace the ipykernel dependency with an IPython dependency? #409

martinRenou opened this issue Dec 15, 2021 · 2 comments · Fixed by #410

Comments

@martinRenou
Copy link
Member

Describe the issue

In the setup.py file and in the conda-forge recipe, there is an ipykernel dependency that we could maybe get rid of. We should probably reduce the dependency to an IPython dependency, which we use directly in the codebase.

@martinRenou
Copy link
Member Author

The conda-forge bot is complaining about the following:

Missing dependencies:
- traitlets
- jupyter-packaging
- numpy
- ipython
- pillow
- ipython_genutils

Unused dependencies:
- six
- ipykernel

@stonebig
Copy link
Contributor

stonebig commented Jan 15, 2022

is it still mandatory to have the contraint ipython<8 ? (ipympl is the only package with that in my stack)
and recompiling it is a not trivial problem

stonebig added a commit to stonebig/ipympl that referenced this issue Jan 15, 2022
now that ipython-8 is there, maybe it's not a problem matplotlib#409
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants