Update binder2 #555
Merged
Update binder2 #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the mybinder link that the README will effectively point to (but it will be on It appears that the binder workflow is using the github action from |
martinRenou
reviewed
May 28, 2024
| - jupyterlab~=4.0 | ||
| - retrolab |
There was a problem hiding this comment.
Should we replace this by notebook 7?
| issue_number: context.issue.number, | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| body: `[](https://mybinder.org/v2/gh/${PR_HEAD_USERREPO}/${PR_HEAD_REF}?urlpath=retro/notebooks/docs/examples/full-example.ipynb) :point_left: Launch a binder notebook on branch _${PR_HEAD_USERREPO}/${PR_HEAD_REF}_` |
There was a problem hiding this comment.
If we use notebook 7, this url could point to notebooks/docs/examples/full-example.ipynb ? (to be verified)
|
Thanks for looking into it! |
ianthomas23
force-pushed
the
update-binder2
branch
from
1afa1ed to
61143bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the binder config, both in the top of the README and in the github actions PR workflow. Take 2.