Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ui-test dependencies #569

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Update ui-test dependencies #569

merged 1 commit into from
Dec 17, 2024

Conversation

ianthomas23
Copy link
Member

ui-tests are currently failing, initially not able to page.filebrowser.openDirectory(). I think this is due to old galata test dependencies not working with latest JupyterLab that is used to build and run. Updating the test dependencies works for me locally, so trying here in CI.

@ianthomas23 ianthomas23 added the dependencies Pull requests that update a dependency file label Dec 17, 2024
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch matplotlib/ipympl/fix-ui-tests

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 1efb600 into main Dec 17, 2024
11 checks passed
@martinRenou martinRenou deleted the fix-ui-tests branch December 17, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants