Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against stable MSC1772 spaces identifiers #107

Merged
merged 3 commits into from
May 17, 2021
Merged

Conversation

clokep
Copy link
Member

@clokep clokep commented Apr 30, 2021

Based on #99

Blocked on FCP matrix-org/matrix-spec-proposals#1772.

@clokep clokep force-pushed the clokep/stable-spaces branch from f8547ed to 97146f7 Compare May 5, 2021 14:26
@clokep
Copy link
Member Author

clokep commented May 5, 2021

Annoyingly this will fail until there's a stable release of Synapse that supports this. 😢 (This will be v1.34.0.)

@clokep clokep marked this pull request as ready for review May 5, 2021 15:46
@kegsay
Copy link
Member

kegsay commented May 14, 2021

This is presumably because Complement doesn't support same named branches when checking out branches to test under CI?

@clokep
Copy link
Member Author

clokep commented May 14, 2021

This is presumably because Complement doesn't support same named branches when checking out branches to test under CI?

Yes, and uses synapse stable instead of develop.

@clokep clokep requested a review from a team May 17, 2021 13:37
@clokep clokep changed the title Use stable MSC1772 spaces identifiers Test against stable MSC1772 spaces identifiers May 17, 2021
@clokep clokep merged commit 8bb143c into master May 17, 2021
@clokep clokep deleted the clokep/stable-spaces branch May 17, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants