Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unblacklist user_query_keys_test for synapse #198

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

DMRobertson
Copy link
Contributor

After my changes in matrix-org/synapse#10593

@DMRobertson DMRobertson requested a review from a team August 23, 2021 13:35
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable since the tests pass. 😄

@DMRobertson
Copy link
Contributor Author

Hmmm. I can't see TestKeysQueryWithDeviceIDAsObjectFails in the CI run anywhere---does that mean this test isn't getting run today (even for dendrite?)

@DMRobertson
Copy link
Contributor Author

Hmmm. I can't see TestKeysQueryWithDeviceIDAsObjectFails in the CI run anywhere---does that mean this test isn't getting run today (even for dendrite?)

Can see it in the raw logs---just couldn't search for it with Ctrl-F while viewing the output from github actions. Assuming it's a PICNIC on my part.

@DMRobertson DMRobertson merged commit 42389f3 into master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants