This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Avoid double logging #227
Merged
Avoid double logging #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we log everything to stderr AND to LOG_DIR, doubling log volumes.
|
sirupsen/logrus#328 made this as the suggestion for removing logging when you have a hook doing most of the work. |
jcgruenhage
reviewed
May 24, 2018
| @@ -105,7 +105,7 @@ BIND_ADDRESS=:4050 DATABASE_TYPE=sqlite3 DATABASE_URL=go-neb.db?_busy_timeout=50 | |||
| - `DATABASE_URL` is where to find the database file. One will be created if it does not exist. It is a URL so parameters can be passed to it. We recommend setting `_busy_timeout=5000` to prevent sqlite3 "database is locked" errors. | |||
| - `BASE_URL` should be the public-facing endpoint that sites like Github can send webhooks to. | |||
| - `CONFIG_FILE` is the path to the configuration file to read from. This isn't included in the example above, so Go-NEB will operate in HTTP mode. | |||
|
|
|||
| - `LOG_DIR` is a directory that log files will be written to, with log rotation enabled. If set, logging to stderr will be disabled. | |||
There was a problem hiding this comment.
Surely logrus would default to logging to stdout, not stderr, right? So setting this should disable both logging to stdout and stderr.
There was a problem hiding this comment.
From https://github.com/sirupsen/logrus/blob/master/README.md#example
// Output to stdout instead of the default stderr
// Can be any io.Writer, see below for File example
log.SetOutput(os.Stdout)
There was a problem hiding this comment.
Weird.. but doesn't matter, since we log to "Discard" now.
Good to know though, I'll keep it in mind.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if LOG_DIR is set, we log everything to stderr and additionally log to the three files in LOG_DIR.
This should disable logging to stderr if we are explicitly setting a LOG_DIR.