This repository has been archived by the owner on Dec 12, 2022. It is now read-only.
Replace MXKTools's sanitiseHTML with DTCoreText's will flush callback. #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Match h1/h2 size to h3 in CSS.
Add check for kMXKToolsBlockquoteMarkAttribute.
Remove old sanitiseHTML method from MXKTools.
pixlwave
force-pushed
the
doug/5165_use_dtcoretext_callback
branch
from
585a774 to
cb78f9d
Compare
SBiOSoftWhare
approved these changes
Nov 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-ios#5165.
The block supplied as the
DTWillFlushBlockCallBackoption gets called just before the html builder converts the element into an attributed string. This PR modifies theDTHTMLElementwhenever a tag is found that isn't part of theallowedHTMLTagsarray.Instead of removing h1/h2 tags, they are now simply formatted similarly to h3 tags using the CSS option.
The image handler isn't used in MatrixKit, but instead is used in Element.