Include decryption block inside synchronisation block

matrix-org · Aug 30, 2022 · 02b3541 · 02b3541
1 parent cc53e14
commit 02b3541
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/MatrixSDK/Crypto/MXOlmDevice.m b/MatrixSDK/Crypto/MXOlmDevice.m
@@ -544,17 +544,16 @@ - (void)performGroupSessionOperationWithSessionId:(NSString*)sessionId senderKey
 
     if (enableCache)
     {
-        __block MXOlmInboundGroupSession *session;
         @synchronized (self.inboundGroupSessionCache)
         {
-            session = (MXOlmInboundGroupSession *)[self.inboundGroupSessionCache get:sessionId];
+            MXOlmInboundGroupSession *session = (MXOlmInboundGroupSession *)[self.inboundGroupSessionCache get:sessionId];
             if (!session)
             {
                 session = [store inboundGroupSessionWithId:sessionId andSenderKey:senderKey];
                 [self.inboundGroupSessionCache put:sessionId object:session];
             }
+            block(session);
         }
-        block(session);
     }
     else
     {