Fix e2ee regression introduced by #1358 #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The source of truth for the encryption of a room is back to `MXRoomSummary.isEncrypted`, which is a rollback of #1358. The additional change of this PR is that on every send, there is a check if this value is aligned with the one in the crypto store. There is also some error logs if something tries to reset `MXRoomSummary.isEncrypted`.
manuroe
force-pushed
the
manu/5564_e2e_regression
branch
from
b53a242 to
21fa803
Compare
pixlwave
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes element-hq/element-ios#5564.
The source of truth for the encryption of a room is back to
MXRoomSummary.isEncrypted, which is a rollback of #1358.The additional change of this PR is that on every send, there is a check if this value is aligned with the one in the crypto store.
There is also some error logs if something tries to reset
MXRoomSummary.isEncrypted.