Add integration tests to the CI #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are useful to keep the counter of remaining sessions after the test
The method is optional in the protocol but some swift code requires it. Stub it to make swift code work.
we already have a dedicated test plan for them
Codecov Report
@@ Coverage Diff @@
## develop #1537 +/- ##
============================================
+ Coverage 12.03% 51.23% +39.19%
============================================
Files 514 514
Lines 83966 83952 -14
Branches 35849 37412 +1563
============================================
+ Hits 10105 43011 +32906
+ Misses 73493 39837 -33656
- Partials 368 1104 +736
Continue to review full report at Codecov.
|
manuroe
requested review from
a team and
stefanceriu
and removed request for
a team
stefanceriu
approved these changes
Jul 28, 2022
| jobs: | ||
| integration-tests: | ||
| name: Integration Tests | ||
| runs-on: macos-11 |
There was a problem hiding this comment.
Element is using macos-12. We can start using that in the SDK as well but it's probably best done as a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings a new test plan called AllWorkingTests where 482 out of 805 tests are disabled because:
We will be able to re-enable those tests later but let's start with a stable and working subset.
The main change is the tests code is to ensure that all
MXSessions are closed at the end of each test. Else, we have this assert. FTR, this assert avoids to avoid remaining running MXSessions that slow down the tests to the death.The coverage jumped to 51.2%: