-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(refactor) project settings update #1543
(refactor) project settings update #1543
Conversation
(cherry picked from commit 0aa5a4e)
Codecov Report
@@ Coverage Diff @@
## develop #1543 +/- ##
===========================================
- Coverage 42.10% 42.10% -0.01%
===========================================
Files 515 515
Lines 84113 84113
Branches 37064 37063 -1
===========================================
- Hits 35418 35414 -4
- Misses 47663 47668 +5
+ Partials 1032 1031 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mredig, thanks for this PR. Looks fine to me, but yes please could you revert the deployment target back to iOS 11 for us 🙏.
targets reverted :) |
Thanks @mredig |
updated to match Xcode recommended settings. There were some target version bumps, so if you want me to revert those, just lemme know.
Signed-off-by: Michael Redig hybrids-07-baggage at icloud.com
Pull Request Checklist