Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting a log level of .none. #1557

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Conversation

pixlwave
Copy link
Member

Fixes #1550. There was a bug where setting the log level to .none had no effect if a call to MXLogDebug (etc) had already been called as the default configuration would already have been applied.

@pixlwave pixlwave requested a review from stefanceriu August 22, 2022 10:48
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2022

Codecov Report

Merging #1557 (8d9ec95) into develop (874699b) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #1557      +/-   ##
===========================================
- Coverage    45.24%   45.23%   -0.02%     
===========================================
  Files          520      520              
  Lines        84790    84791       +1     
  Branches     37527    37523       -4     
===========================================
- Hits         38365    38356       -9     
- Misses       45329    45333       +4     
- Partials      1096     1102       +6     
Impacted Files Coverage Δ
MatrixSDK/Utils/MXLog.swift 53.03% <0.00%> (-0.41%) ⬇️
MatrixSDK/JSONModels/MXJSONModel.h 90.62% <0.00%> (-3.13%) ⬇️
...rypto/KeySharing/MXOutgoingRoomKeyRequestManager.m 73.70% <0.00%> (-0.94%) ⬇️
MatrixSDK/Crypto/KeyBackup/MXKeyBackup.m 68.77% <0.00%> (-0.89%) ⬇️
MatrixSDK/Data/Store/MXFileStore/MXFileStore.m 62.04% <0.00%> (-0.19%) ⬇️
MatrixSDK/MXSession.m 48.54% <0.00%> (-0.10%) ⬇️
MatrixSDK/MXRestClient.m 48.61% <0.00%> (-0.10%) ⬇️
...Data/Store/MXRealmCryptoStore/MXRealmCryptoStore.m 66.34% <0.00%> (+0.14%) ⬆️
MatrixSDK/Crypto/MXCrypto.m 55.13% <0.00%> (+0.14%) ⬆️
MatrixSDK/Space/MXSpaceService.swift 75.22% <0.00%> (+0.45%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pixlwave pixlwave merged commit 62ec1ec into develop Aug 22, 2022
@pixlwave pixlwave deleted the doug/1550-mxloglevel-none branch August 22, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change verbosity of MXLog
3 participants