Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enableNewClientInformationFeature sdk option (PSG-799) #1588

Merged
merged 7 commits into from
Sep 30, 2022

Conversation

ismailgulek
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Base: 13.34% // Head: 13.51% // Increases project coverage by +0.17% 🎉

Coverage data is based on head (b2f52a3) compared to base (89f6a07).
Patch coverage: 84.44% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1588      +/-   ##
===========================================
+ Coverage    13.34%   13.51%   +0.17%     
===========================================
  Files          537      541       +4     
  Lines        86338    86542     +204     
  Branches     36700    36767      +67     
===========================================
+ Hits         11518    11693     +175     
- Misses       74380    74407      +27     
- Partials       440      442       +2     
Impacted Files Coverage Δ
MatrixSDKTests/Mocks/MXRestClientStub.m 61.11% <50.00%> (-38.89%) ⬇️
MatrixSDK/MXSession.m 7.99% <66.66%> (+0.43%) ⬆️
...ClientInformation/MXClientInformationService.swift 73.84% <73.84%> (ø)
...SDKTests/MXClientInformationServiceUnitTests.swift 96.90% <96.90%> (ø)
MatrixSDK/MXSDKOptions.m 100.00% <100.00%> (ø)
...rypto/KeyBackup/Data/MXKeyBackupVersion+Stub.swift 0.00% <0.00%> (ø)
...K/Crypto/SecretStorage/MXCryptoSecretStoreV2.swift 0.00% <0.00%> (ø)
MatrixSDKTests/MXHTTPAdditionalHeadersUnitTests.m 85.10% <0.00%> (+12.76%) ⬆️
MatrixSDK/Data/MXAccountData.m 31.81% <0.00%> (+13.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ismailgulek ismailgulek marked this pull request as ready for review September 29, 2022 15:05
@ismailgulek ismailgulek requested review from a team and paleksandrs and removed request for a team September 29, 2022 15:05
Copy link
Contributor

@paleksandrs paleksandrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, some more comments. Maybe something will be useful.

MatrixSDKTests/MXClientInformationServiceUnitTests.swift Outdated Show resolved Hide resolved
MatrixSDKTests/MXClientInformationServiceUnitTests.swift Outdated Show resolved Hide resolved
MatrixSDKTests/MXClientInformationServiceUnitTests.swift Outdated Show resolved Hide resolved
MatrixSDKTests/MXClientInformationServiceUnitTests.swift Outdated Show resolved Hide resolved
MatrixSDKTests/MXClientInformationServiceUnitTests.swift Outdated Show resolved Hide resolved
@ismailgulek ismailgulek merged commit 49bb307 into develop Sep 30, 2022
@ismailgulek ismailgulek deleted the ismail/device_manager_labs branch September 30, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants