Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or skip integrations tests #1628

Merged
merged 7 commits into from
Nov 14, 2022
Merged

Fix or skip integrations tests #1628

merged 7 commits into from
Nov 14, 2022

Conversation

manuroe
Copy link
Contributor

@manuroe manuroe commented Nov 3, 2022

As the graph below shows, some are definitely broken. Others are flakey.
Some tests has been fixed. Others are just skipped in the "working tests" plan.

image

For further flakiness investigation, here are the tests that failed only once the past 3 months:

gh-single-failures

…nd testUpgradeSpaceChild()

It seems we have race conditions that we could improve by adding some sleep(1) before REST request but they are still not 100% reliable. So skip them.

testUpdateChildSuggestion is broken since 2022-09-16 without good reasons. testUpgradeSpaceChild() is bit more random
Failure on the 3 last months:
MXAggregatedReactionTests testUnreactOnEventReactedByOther: 5
MXCryptoSecretStorageTests testDeleteSecret: 4
MXAggregatedReactionTests testAggregationsListener: 2
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 16.16% // Head: 16.17% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (e25224c) compared to base (cf61531).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1628      +/-   ##
===========================================
+ Coverage    16.16%   16.17%   +0.01%     
===========================================
  Files          580      580              
  Lines        91432    91403      -29     
  Branches     38555    38548       -7     
===========================================
+ Hits         14777    14783       +6     
+ Misses       76176    76141      -35     
  Partials       479      479              
Impacted Files Coverage Δ
MatrixSDKTests/MXNotificationCenterTests.m 0.00% <0.00%> (ø)
MatrixSDKTests/MXRestClientTests.m 0.00% <0.00%> (ø)
MatrixSDKTests/MXHTTPAdditionalHeadersUnitTests.m 85.10% <0.00%> (+12.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@manuroe
Copy link
Contributor Author

manuroe commented Nov 4, 2022

We have new tests failing since last week:

MXDehydrationTests testDehydrateDevice: 22
MXDehydrationTests testDehydrateDeviceSeenByOther: 22
MXDehydrationTests testReceiveMessageWhileBeingSignedOffWithDeviceRehydration: 22
MXDehydrationTests testDehydrateDeviceAndClaimDehydratedDevice: 22
MXDehydrationTests testReceiveLiveMessageAfterDeviceRehydration: 22

We can see them in a filtered view of the failing tests.
image

We should ignore them. This is due to regression on synapse in 1.70.1 (b=HEAD,5889151). It will be fixed in 1.71.0 thanks to this PR.

…ntMatchCondition

as we test a different thing now
@manuroe
Copy link
Contributor Author

manuroe commented Nov 4, 2022

PR is ready to review even if the CI is complaining about the 5 tests listed above.
The CI should turn green on the next synapse release

@manuroe manuroe requested review from a team and Velin92 and removed request for a team November 4, 2022 12:10
Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manuroe manuroe merged commit 554db86 into develop Nov 14, 2022
@manuroe manuroe deleted the manu/fix_integrations_tests branch November 14, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants