-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix or skip integrations tests #1628
Conversation
…nd testUpgradeSpaceChild() It seems we have race conditions that we could improve by adding some sleep(1) before REST request but they are still not 100% reliable. So skip them. testUpdateChildSuggestion is broken since 2022-09-16 without good reasons. testUpgradeSpaceChild() is bit more random
Failure on the 3 last months: MXAggregatedReactionTests testUnreactOnEventReactedByOther: 5 MXCryptoSecretStorageTests testDeleteSecret: 4 MXAggregatedReactionTests testAggregationsListener: 2
Codecov ReportBase: 16.16% // Head: 16.17% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1628 +/- ##
===========================================
+ Coverage 16.16% 16.17% +0.01%
===========================================
Files 580 580
Lines 91432 91403 -29
Branches 38555 38548 -7
===========================================
+ Hits 14777 14783 +6
+ Misses 76176 76141 -35
Partials 479 479
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
We have new tests failing since last week:
We can see them in a filtered view of the failing tests. We should ignore them. This is due to regression on synapse in 1.70.1 (b=HEAD,5889151). It will be fixed in 1.71.0 thanks to this PR. |
…ntMatchCondition as we test a different thing now
PR is ready to review even if the CI is complaining about the 5 tests listed above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As the graph below shows, some are definitely broken. Others are flakey.
Some tests has been fixed. Others are just skipped in the "working tests" plan.
For further flakiness investigation, here are the tests that failed only once the past 3 months: