Disable notification decryption for Crypto V2 #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/disable_notifications
branch
from
710d5db to
e4ef220
Compare
Anderas
changed the title
Anderas
requested review from
a team and
paleksandrs
and removed request for
a team
paleksandrs
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust-based crypto uses a database which is not multi-process safe and cannot be used from foreground and background process simultaneously. This will be addressed in a future PR, but before we have multi-process safe database, we are simply not going to be decrypting notifications, only displaying their arrival.
Some other changes include:
isUntrustedproperty of events until rust adds an "undecided" state for trust