Use correct next users with keys query #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/fix_query
branch
2 times, most recently
from
e1b0a0a to
6f83902
Compare
Anderas
requested review from
a team and
Velin92
and removed request for
a team
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1726 +/- ##
===========================================
+ Coverage 37.38% 37.40% +0.02%
===========================================
Files 612 612
Lines 96171 96206 +35
Branches 41586 41596 +10
===========================================
+ Hits 35952 35986 +34
+ Misses 59164 59162 -2
- Partials 1055 1058 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Velin92
reviewed
Mar 2, 2023
| currentQuery = .init(users: users, task: next) | ||
| if let nextTask = nextTask { | ||
| log("... query for \(users) completed, starting next pending query.") | ||
| currentQuery = .init(users: nextUsers, task: nextTask) |
There was a problem hiding this comment.
maybe is a personal thing, but I don't like inferred constructor, could we use the constructor directly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a minor bug where starting the next pending
keys/querywould use the wrong list of users used to deduplicate requests. The consequence of this bug is that we may be executing slightly more requests than necessary