Groups: self-management of membership of groups #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Handle the list of the groups from the server sync response. element-hq/riot-meta#114
manuroe
reviewed
Dec 5, 2017
| @param success A block object called when the operation succeeds. | ||
| @param failure A block object called when the operation fails. | ||
| */ | ||
| - (void)asyncGroups:(void (^)(NSArray<MXGroup *> *groups))success |
There was a problem hiding this comment.
Could you please update the files structure provided in this file header?
MatrixSDK/JSONModels/MXJSONModels.h
Outdated
|
|
||
| @property (nonatomic) NSArray<NSString*> *users; | ||
|
|
||
| @property (nonatomic) NSDictionary *roles; |
MatrixSDK/JSONModels/MXJSONModels.h
Outdated
|
|
||
| @property (nonatomic) NSArray<NSString*> *rooms; | ||
|
|
||
| @property (nonatomic) NSDictionary *categories; |
MatrixSDK/JSONModels/MXJSONModels.m
Outdated
| @@ -1222,6 +1256,39 @@ + (id)modelFromJSON:(NSDictionary *)JSONDictionary | |||
|
|
|||
| @end | |||
|
|
|||
| @implementation MXGroupsSyncResponse | |||
|
|
|||
| // Override the default Mantle modelFromJSON method to convert groups lists. | |||
There was a problem hiding this comment.
We do not use Mantle anymore.
MatrixSDK/JSONModels/MXJSONModels.m
Outdated
| MXGroupProfile *profile = [[MXGroupProfile alloc] init]; | ||
| if (profile) | ||
| { | ||
| NSDictionary *dict = [MXJSONModel removeNullValuesInJSON:JSONDictionary]; |
There was a problem hiding this comment.
[MXJSONModel removeNullValuesInJSON:] should not be required. It was useful for MXEvent at the beginning of the project
MatrixSDK/JSONModels/MXJSONModels.m
Outdated
| MXGroupSummaryRoomsSection *roomsSection = [[MXGroupSummaryRoomsSection alloc] init]; | ||
| if (roomsSection) | ||
| { | ||
| NSDictionary *dict = [MXJSONModel removeNullValuesInJSON:JSONDictionary]; |
There was a problem hiding this comment.
useless [MXJSONModel removeNullValuesInJSON:]
MatrixSDK/JSONModels/MXJSONModels.m
Outdated
| MXGroupRoom *room = [[MXGroupRoom alloc] init]; | ||
| if (room) | ||
| { | ||
| NSDictionary *dict = [MXJSONModel removeNullValuesInJSON:JSONDictionary]; |
There was a problem hiding this comment.
useless [MXJSONModel removeNullValuesInJSON:]
MatrixSDK/JSONModels/MXJSONModels.m
Outdated
| MXGroupRooms *rooms = [[MXGroupRooms alloc] init]; | ||
| if (rooms) | ||
| { | ||
| NSDictionary *dict = [MXJSONModel removeNullValuesInJSON:JSONDictionary]; |
There was a problem hiding this comment.
useless [MXJSONModel removeNullValuesInJSON:]
MatrixSDK/JSONModels/MXJSONModels.m
Outdated
| MXGroupUser *user = [[MXGroupUser alloc] init]; | ||
| if (user) | ||
| { | ||
| NSDictionary *dict = [MXJSONModel removeNullValuesInJSON:JSONDictionary]; |
There was a problem hiding this comment.
useless [MXJSONModel removeNullValuesInJSON:]
MatrixSDK/JSONModels/MXJSONModels.m
Outdated
| MXGroupUsers *users = [[MXGroupUsers alloc] init]; | ||
| if (users) | ||
| { | ||
| NSDictionary *dict = [MXJSONModel removeNullValuesInJSON:JSONDictionary]; |
There was a problem hiding this comment.
useless [MXJSONModel removeNullValuesInJSON:]
manuroe
approved these changes
Dec 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
element-hq/riot-meta#114