MX3PidAddManager: Add User-Interactive Auth to /account/3pid/add #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [self tryFinaliseAddEmailSession:threePidAddSession authParams:nil success:success failure:^(NSError * _Nonnull error) { | ||
| MXStrongifyAndReturnIfNil(self); | ||
|
|
||
| NSDictionary *authParams = [self authParamsFromError:error andPassword:password]; |
There was a problem hiding this comment.
No specific error catching here, it can lead to an infinite loop.
There was a problem hiding this comment.
[self authParamsFromError: andPassword:] that can return nil will ensure there is no infinite loop.
| MXStrongifyAndReturnIfNil(self); | ||
|
|
||
| NSDictionary *authParams = [self authParamsFromError:error andPassword:password]; | ||
| if (authParams) |
There was a problem hiding this comment.
Same as above no specific error catching here, it can lead to an infinite loop.
SBiOSoftWhare
approved these changes
Oct 24, 2019
SBiOSoftWhare
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
element-hq/element-ios#2744