MXTaggedEvents: Expose "m.tagged_events" according to (MSC2437) #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yostyle
force-pushed
the
yostyle/tagged_events
branch
from
57263b2 to
aef2ccd
Compare
manuroe
reviewed
Dec 2, 2020
manuroe
approved these changes
Dec 3, 2020
giomfo
reviewed
Dec 3, 2020
|
|
||
| jsonDictionary[kTaggedEventInfoKewordsJSONKey] = _keywords; | ||
| jsonDictionary[kTaggedEventInfoOriginServerTsJSONKey] = @(_originServerTs); | ||
| jsonDictionary[kTaggedEventInfoTaggedAtJSONKey] = @(_taggedAt); |
There was a problem hiding this comment.
I would check whether each value is actually defined before adding them to the dict
| NSMutableDictionary<NSString*, NSDictionary<NSString*, NSDictionary*>* > *updatedTags = [_tags mutableCopy]; | ||
| if (!updatedTags) | ||
| { | ||
| updatedTags = [NSMutableDictionary dictionary]; |
There was a problem hiding this comment.
I would not allocate this dictionary here. I would not change/update _tags
| } | ||
| } | ||
|
|
||
| _tags = updatedTags; |
There was a problem hiding this comment.
I would update _tags only in case of an actual change
MatrixSDK/Utils/MXTools.m
Outdated
| @@ -116,6 +116,7 @@ + (void)initialize | |||
| kMXEventTypeStringSecretRequest, | |||
| kMXEventTypeStringSecretSend, | |||
| kMXEventTypeStringSecretStorageDefaultKey, | |||
| kMXEventTypeStringTaggedEvents, | |||
yostyle
force-pushed
the
yostyle/tagged_events
branch
from
27b6a71 to
0035edf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSC: matrix-org/matrix-spec-proposals#2437