Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread list ordering by last reply #2253

Merged
merged 6 commits into from
Mar 23, 2022
Merged

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Mar 22, 2022

Currently trying to get a relevant set of tests coming. Watch this space

  • Initial thread list fetch in correct ordering
  • re-order thread list on new reply
  • Add state to thread list event

This PR currently has no changelog labels, so will not be included in changelogs.

Add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is plus X-Breaking-Change if it's a breaking change.

@codecov-commenter
Copy link

Codecov Report

Merging #2253 (d46b41f) into develop (75674d9) will decrease coverage by 0.10%.
The diff coverage is 7.84%.

@@             Coverage Diff             @@
##           develop    #2253      +/-   ##
===========================================
- Coverage    58.11%   58.01%   -0.11%     
===========================================
  Files           92       92              
  Lines        16427    16459      +32     
  Branches      3782     3787       +5     
===========================================
+ Hits          9546     9548       +2     
- Misses        6881     6911      +30     
Impacted Files Coverage Δ
src/@types/event.ts 100.00% <ø> (ø)
src/models/event.ts 66.34% <ø> (ø)
src/models/room.ts 53.58% <7.84%> (-2.02%) ⬇️
src/models/beacon.ts 100.00% <0.00%> (+6.81%) ⬆️

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane otherwise

src/models/room.ts Outdated Show resolved Hide resolved
src/models/room.ts Show resolved Hide resolved
src/models/room.ts Show resolved Hide resolved
@germain-gg germain-gg merged commit 6192325 into develop Mar 23, 2022
@germain-gg germain-gg deleted the gsouquet/threads-list branch March 23, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants