-
-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with duplicated MatrixEvent objects around threads #2256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 thank you for the tests
Codecov Report
@@ Coverage Diff @@
## develop #2256 +/- ##
===========================================
+ Coverage 58.38% 58.55% +0.16%
===========================================
Files 91 91
Lines 16313 16285 -28
Branches 3763 3758 -5
===========================================
+ Hits 9525 9535 +10
+ Misses 6788 6750 -38
|
Fixes element-hq/element-web#21466
Believably fixes element-hq/element-web#21533
This PR currently has no changelog labels, so will not be included in changelogs.
Add one of:
T-Deprecation
,T-Enhancement
,T-Defect
,T-Task
to indicate what type of change this is plusX-Breaking-Change
if it's a breaking change.