Fix issue in sync when crypto is not supported by client #2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Z-Community-PR
t3chguy
requested review from
t3chguy
and removed request for
germain-gg,
florianduros and
robintown
t3chguy
added
the
backport staging
germain-gg
previously requested changes
Sep 30, 2022
There was a problem hiding this comment.
Thank you for your pull request!
I believe it would be important to add a smoke test to ensure that the js-sdk can process a sync when the crypto layer is missing
If I look a little further at this, I can see that the type definition here fails to mention that the crypto property can be undefined (see
Line 390 in e1edd84
|
/me will handle this and write a test, thanks for review @gsouquet and thanks @stas-demydiuk for the report & fix |
germain-gg
approved these changes
Sep 30, 2022
RiotRobot
pushed a commit
that referenced
this pull request
Sep 30, 2022
Co-authored-by: Michael Telatynski <[email protected]> (cherry picked from commit 9bb5afe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Matrix client is initialized without crypto support it now breaks in the sync as starting from matrix-js-sdk 19.7.0 the additional code was added that directly access the client's crypto feature.
This PR is aimed to fix the issue by introducing the additional check that crypto is actually available before accessing it
Signed-off-by: Stanislav Demydiuk [email protected]
Checklist
Here's what your changelog entry will look like:
🐛 Bug Fixes