-
-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer stable /timestamp_to_event
endpoint first - MSC3030
#2915
Prefer stable /timestamp_to_event
endpoint first - MSC3030
#2915
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With my web hat on, this does need a test to ensure the correct endpoints are called in fallback scenarios (if we're going that route). Otherwise, the unstable-stable flag or version checks need to be tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is looking better - thanks for adding the test! Just some points on the code itself and this should be fine to land.
…to-event Conflicts: spec/unit/matrix-client.spec.ts src/client.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MadLittleMods thank you for all your work on this. With the little changes I added, it looks great.
Co-authored-by: Eric Eastwood <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise lgtm - thanks for taking a look
Prefer stable
/timestamp_to_event
endpoint first, then fallback to the unstable MSC3030 prefixed version.MSC3030 has been merged into the spec.
Stabilized in Synapse via matrix-org/synapse#14471
Dev notes
Add console color codes
Todo
Checklist
Sign-off given on the changes (see CONTRIBUTING.md)This change is marked as an internal change (Task), so will not be included in the changelog.