Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element-R: Connect device to key backup when crypto is created #3784

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Element-R: Connect device to key backup when crypto is created #3784

merged 1 commit into from
Oct 9, 2023

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Oct 6, 2023 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Fixes element-hq/element-web#26316

Here's what your changelog entry will look like:

🐛 Bug Fixes

@florianduros florianduros force-pushed the florianduros/elementr/key-backup-connection-refresh branch from 877c482 to b5c959a Compare October 6, 2023 08:43
@florianduros florianduros marked this pull request as ready for review October 6, 2023 09:05
@florianduros florianduros requested a review from a team as a code owner October 6, 2023 09:05
germain-gg
germain-gg approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane, thank you

@richvdh richvdh removed their request for review October 9, 2023 10:46
@florianduros florianduros added this pull request to the merge queue Oct 9, 2023
Merged via the queue into develop with commit bb8a894 Oct 9, 2023
@florianduros florianduros deleted the florianduros/elementr/key-backup-connection-refresh branch October 9, 2023 14:25
@florianduros florianduros mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germain-gg germain-gg germain-gg approved these changes

@andybalaam andybalaam Awaiting requested review from andybalaam andybalaam was automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Element-R: Device not connected to key backup after a log in or refresh
2 participants
@florianduros @germain-gg