Bump minimum spec version to v1.5 #3970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ftr, the js-sdk could probably go as far as v1.6 if it wanted to. By supporting v1.5, there's already a few servers out there which would no longer be supported - going to v1.6 doesn't appear to change that. |
|
So the reason I went with 1.5 is that 1.6 wasn't released until 14 February 2023. So if we went with 1.6, we wouldn't actually be supporting the spec from a year ago. (We could bump to 1.6 as soon as 14 February 2024 arrives.) |
|
Ah, the readme says "last 4", which is meant to be roughly 1 year. Considering 1.9 just came out though, it's hard to consider it one of the 4 indeed. |
t3chguy
requested changes
Dec 20, 2023
Agreed, but that can be done later. It's just tech debt. There's no need to block this change on that work. |
t3chguy
approved these changes
Dec 21, 2023
|
Issue filed at #3972 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Dec 21, 2023
|
This will need matrix-org/matrix-react-sdk#12081 and element-hq/element-web#26796 to land first. |
|
And probably wants to be a major version bump |
richvdh
added a commit
that referenced
this pull request
Jan 18, 2024
This commit does two things: * It puts the "minimum supported matrix version" from v1.5 back down to v1.1. In other words, it is a partial revert of #3970. (Partial, because we don't need to update the tests.) We're doing this largely because #3970 was introduced without a suitable announcement and deprecation policy. We haven't yet decided if the js-sdk's spec support policy needs to change, or if we will re-introduce this change in future in a more graceful manner. * It increases the "maximum supported matrix version" from v1.5 up to v1.9. Previously, the two concepts were tied together, but as discussed at length in #3915 (comment), this is incorrect. Unfortunately, we have no real way of testing whether it is true that the js-sdk actually works with a server which supports *only* v1.9, but as per the comment above, we can't do much about that. Fixes #3915.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 18, 2024
This commit does two things: * It puts the "minimum supported matrix version" from v1.5 back down to v1.1. In other words, it is a partial revert of #3970. (Partial, because we don't need to update the tests.) We're doing this largely because #3970 was introduced without a suitable announcement and deprecation policy. We haven't yet decided if the js-sdk's spec support policy needs to change, or if we will re-introduce this change in future in a more graceful manner. * It increases the "maximum supported matrix version" from v1.5 up to v1.9. Previously, the two concepts were tied together, but as discussed at length in #3915 (comment), this is incorrect. Unfortunately, we have no real way of testing whether it is true that the js-sdk actually works with a server which supports *only* v1.9, but as per the comment above, we can't do much about that. Fixes #3915.
RiotRobot
pushed a commit
that referenced
this pull request
Jan 18, 2024
This commit does two things: * It puts the "minimum supported matrix version" from v1.5 back down to v1.1. In other words, it is a partial revert of #3970. (Partial, because we don't need to update the tests.) We're doing this largely because #3970 was introduced without a suitable announcement and deprecation policy. We haven't yet decided if the js-sdk's spec support policy needs to change, or if we will re-introduce this change in future in a more graceful manner. * It increases the "maximum supported matrix version" from v1.5 up to v1.9. Previously, the two concepts were tied together, but as discussed at length in #3915 (comment), this is incorrect. Unfortunately, we have no real way of testing whether it is true that the js-sdk actually works with a server which supports *only* v1.9, but as per the comment above, we can't do much about that. Fixes #3915. (cherry picked from commit c885542)
|
For the record: this got reverted in #4014. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only claim to support a year of spec releases, so this should be fine.
Part of: #3915
Here's what your changelog entry will look like:
🚨 BREAKING CHANGES