Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Bump matrix-sdk-crypto-wasm to 3.6.0" #3991

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Revert "Bump matrix-sdk-crypto-wasm to 3.6.0" #3991

merged 1 commit into from
Jan 8, 2024

Conversation

andybalaam
Copy link
Member

@andybalaam andybalaam commented Jan 8, 2024 •
edited by github-actions bot
Loading

Reverts #3989

Since it appears to cause https://github.com/matrix-org/element-web-rageshakes/issues/23557:

2024-01-08T15:59:21.961Z I INFO matrix_sdk_indexeddb::crypto_store::migrations: Fixing inbound group session data keys
    row_count=153771
    at /home/runner/.cargo/git/checkouts/matrix-rust-sdk-1f4927f82a3d27bb/3e17fc2/crates/matrix-sdk-indexeddb/src/crypto_store/migrations.rs:327
2024-01-08T15:59:21.981Z E Unable to load session Error: invalid type: boolean `false`, expected u8

(This is a failure to upgrade the DB when using Element R.)

Here's what your changelog entry will look like:

🐛 Bug Fixes

  • Revert "Bump matrix-sdk-crypto-wasm to 3.6.0" (#3991). Contributed by @andybalaam.

@andybalaam andybalaam requested a review from a team as a code owner January 8, 2024 16:31
@andybalaam andybalaam requested a review from t3chguy January 8, 2024 16:31
@andybalaam andybalaam enabled auto-merge January 8, 2024 16:32
@andybalaam andybalaam disabled auto-merge January 8, 2024 16:34
@richvdh richvdh merged commit a597a9d into develop Jan 8, 2024
32 of 34 checks passed
@richvdh richvdh deleted the revert-3989-rav/element-r/rust_sdk_3_6_0 branch January 8, 2024 16:35
@richvdh richvdh mentioned this pull request Jan 8, 2024
Closed
@richvdh
Copy link
Member

richvdh commented Jan 8, 2024

Full details at element-hq/element-web#26837

andybalaam added a commit that referenced this pull request Jan 10, 2024
@andybalaam
Revert "Revert "Bump matrix-sdk-crypto-wasm to 3.6.0 (#3989)" (#3991)"
98898ce 
This reverts commit a597a9d.
@andybalaam andybalaam mentioned this pull request Jan 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 10, 2024
@andybalaam
Revert "Revert "Bump matrix-sdk-crypto-wasm to 3.6.0 (#3989)" (#3991)" (
8df30ed 
#4001)

This reverts commit a597a9d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from matrix-org/element-web-team

Assignees
No one assigned
Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andybalaam @richvdh