Fix test that will break with matrix-sdk-crypto-wasm 13.0.0 #4635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test runs correctly when I run only the |
BillCarsonFr
previously requested changes
Jan 23, 2025
| "Cannot pin identity of unknown user", | ||
| ); | ||
| }); | ||
|
|
||
| it("throws an error for our own user", async () => { | ||
| const ownIdentity = new RustSdkCryptoJs.OwnUserIdentity(); |
There was a problem hiding this comment.
Isn't it more simple to just do
const ownIdentity = { } as unknown as Mocked<RustSdkCryptoJs.OwnUserIdentity>;
Instead of bringing all the key receiver/responder framework?
I added similar tests in this PR https://github.com/matrix-org/matrix-js-sdk/pull/4646/files
There was a problem hiding this comment.
The problem is that pinCurrentUserIdentity uses instanceof to check whether it's an OwnUserIdentity, so it needs a real OwnUserIdentity object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove use of a constructor that never should have been there.
Fixes #4634
Checklist
public/exportedsymbols have accurate TSDoc documentation.