Handle self read receipts for fixing e2e notification counts #974
Conversation
Fixes element-hq/element-web#9421 This also adds a context to the ReEmitter so we have access to the Room at the time of read receipt. Without this, we have to bind handlers to every encrypted room (which is tedious to maintain) or figure out which room `$something` belong to (CPU intensive).
There was a problem hiding this comment.
looks like a good thing to solve, thanks! The code looks like it would work, but not sure the constructor of the client is where I'd expect this to be though when looking for how this works... did you consider putting it in room? You might be able to avoid using the event system (and needing to adjust it) in that case.
|
Putting it in the room pulls it away from the existing code which handles this, and we'd have upwards of a few hundred listeners. |
There was a problem hiding this comment.
Putting it in the room pulls it away from the existing code which handles this, and we'd have upwards of a few hundred listeners.
Ok, not sure why you'd need a listener at all if the object emitting and listening are one and the same, but keeping related code together is good 👍
Fixes element-hq/element-web#9421
This also adds a context to the ReEmitter so we have access to the Room at the time of read receipt. Without this, we have to bind handlers to every encrypted room (which is tedious to maintain) or figure out which room
$somethingbelong to (CPU intensive).