Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCP timeout #129

Open
Spferical opened this issue May 9, 2017 · 4 comments
Open

TCP timeout #129

Spferical opened this issue May 9, 2017 · 4 comments

Comments

@Spferical
Copy link

Right now, the only timeout in the sdk is the server-side sync timeout. No client-side timeout is specified. This means that, under some network conditions, requests may hang indefinitely.

In particular, this makes a thread running client.listen_forever freeze for me once every few days on a VPS or sometimes when moving between wifi networks on a laptop (makes using the sdk for a long-running chatbot kinda annoying).

Passing a timeout into requests.request() seems to fix it, throwing an exception as desired.

@Half-Shot
Copy link
Collaborator

I think having a standard timeout (90 seconds seems reasonable?) would be fine and easy to implement.

@fti7
Copy link

fti7 commented Aug 28, 2019

I think we ran into the same Issue here home-assistant/core#22219
Any Progress?

@3nprob
Copy link

3nprob commented Aug 21, 2021

Looks like this was fixed in e200f0b?

EDIT: ..Which isn't merged. @non-Jedi I know this is years later but are your concerns in #157 addressed?

@non-Jedi
Copy link
Collaborator

Sorry I'm no longer maintaining this. You'll have to ping someone else with commit rights if you want something merged. Glancing at that PR, I certainly wouldn't merge something with so many commits without good commit messages... If that PR does a good job of fixing an issue you're having, I'd squash the commits from that PR down, write good commit messages, and maybe ping @anoadragon453 (pinging you so you can recommend a better person to get PRs merged here if there is anyone) who recently merged a PR in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants