-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TCP timeout #129
Comments
I think having a standard timeout (90 seconds seems reasonable?) would be fine and easy to implement. |
Makes tcp read timeouts actually happen, fixing matrix-org#129.
I think we ran into the same Issue here home-assistant/core#22219 |
Sorry I'm no longer maintaining this. You'll have to ping someone else with commit rights if you want something merged. Glancing at that PR, I certainly wouldn't merge something with so many commits without good commit messages... If that PR does a good job of fixing an issue you're having, I'd squash the commits from that PR down, write good commit messages, and maybe ping @anoadragon453 (pinging you so you can recommend a better person to get PRs merged here if there is anyone) who recently merged a PR in this repo. |
Right now, the only timeout in the sdk is the server-side sync timeout. No client-side timeout is specified. This means that, under some network conditions, requests may hang indefinitely.
In particular, this makes a thread running client.listen_forever freeze for me once every few days on a VPS or sometimes when moving between wifi networks on a laptop (makes using the sdk for a long-running chatbot kinda annoying).
Passing a timeout into requests.request() seems to fix it, throwing an exception as desired.
The text was updated successfully, but these errors were encountered: