Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add cachebuster for i18n #1018

Closed
wants to merge 1 commit into from
Closed

Add cachebuster for i18n #1018

wants to merge 1 commit into from

Conversation

MTRNord
Copy link
Contributor

@MTRNord MTRNord commented Jun 3, 2017

This is fixing the i18n part of element-hq/element-web#4136

@matrixbot
Copy link
Member

Can one of the admins verify this patch?

@ara4n
Copy link
Member

ara4n commented Jun 3, 2017

rather than redownloading i18n every time you launch the app, i'd rather we used the cachebusting webpack already provides by bundling into a directory named with a unique hash. @dbkr may need to comment on the right voodoo for this

@dbkr
Copy link
Member

dbkr commented Jun 7, 2017

Using webpack's cachebusting is not entirely trivial because we'd have to get the bundle hash into the language handler and also the copy-res script (or write a webpack loader to copy the i18n files with webpack itself).

We don't do any of this for images, fonts or the config file. Another option would be to use the app version number as a cachebuster, ie. force re-download every app update?

@dbkr
Copy link
Member

dbkr commented Jan 4, 2018

I think on account of how stale this is, I'm going to close this, since it may not be clear what the correct fix is but it does seem like it's probably not this one - sorry.

@lukebarnard1
Copy link
Contributor

except he didn't close it... 🤔

@MTRNord MTRNord deleted the patch-5 branch April 11, 2018 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants